kbaseapps / kb_staging_exporter

MIT License
0 stars 3 forks source link

Fix tests w/ patched SDK #37

Closed MrCreosote closed 4 months ago

MrCreosote commented 4 months ago

The tests are currently failing because the SDK client in the image is too old to work with the docker server on even the oldest ubuntu version in GHA.

This hack uses the patched SDK with newer docker binaries and copies and alters kb_sdk_actions scripts to run the image as root.

It may be possible in the future to no longer run images as root if we can figure out why the docker changes currently require it, but that's another fix.

It should also be noted that the prior sdk image isn't pinnned, which isn't great. The new image tag doesn't appear to be pinnable either but that may change in the near future.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.96%. Comparing base (333975e) to head (9ea6c38).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #37 +/- ## ======================================= Coverage 55.96% 55.96% ======================================= Files 4 4 Lines 713 713 ======================================= Hits 399 399 Misses 314 314 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MrCreosote commented 4 months ago

I don't know of any, but that might be just because they haven't been run yet. I would assume that the other repos will fail as well