kbaseapps / kb_uploadmethods

MIT License
4 stars 21 forks source link

PTV-1672 fix GFF upload form labels and new dropdown values #323

Closed jkbaumohl closed 3 years ago

jkbaumohl commented 3 years ago

Description of PR purpose/changes

Jira Ticket / Issue

e.g. https://kbase-jira.atlassian.net/browse/DATAUP-X

Testing Instructions

Dev Checklist:

Updating Version and Release Notes (if applicable)

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

jkbaumohl commented 3 years ago

This addresses some form issues that Sam and Jason had with the GFF genome uploader. The ticket is PTV-1672. Addressed are fixing an erroneous error and adding elements to 2 different drop down methods. An upload was tested on CI dev and the form is accurate now and the fields were properly captured in the JSON of the resulting Genome object. I suspect this does not increment the versioning as it is minor form changes.