search

kbaseattic / KBaseFBAModeling

Flux balance modeling service. Deploys both the client and service codes.
MIT License
6 stars 11 forks source link

Removed http substitution in WS URL #58

Closed msneddon closed 6 years ago

msneddon commented 8 years ago

I was debugging uploaders in Appdev, and found that tests in the FBAFileUtil were failing on calls to the WS. I tracked it down to this issue- a substitution for any 'https' found in urls to 'http'! It was probably convenient for testing at some point, but this seems dangerous.

I think HTTP was being redirected to HTTPS previously in CI, but a recent update (either on our end, or maybe one of the perl libs) causes this to fail with a "301 moved permanently" error against appdev and CI. This PR fixes that.

I updated FBAFileUtil to point to my KBaseFBAModeling fork for now, and I know we are using another module for FBA tools, but we probably should make sure we aren't doing this in other places or in the new FBA tools codebase.

samseaver commented 8 years ago

I don't see any substitutions in fba_tools:

https://github.com/kbaseapps/fba_tools/blob/master/lib/fba_tools/fba_toolsImpl.pm

JamesJeffryes commented 6 years ago

@scanon @sychan I think this service is fully retired, so I recommend closing these PRs and archiving the repo

scanon commented 6 years ago

This repo is retired. Closing.