kbaseattic / relation_engine_spec

Specifications and config for the KBase Relation Engine
https://kbase.us
MIT License
0 stars 7 forks source link

Exascale networking - updates #142

Closed ialarmedalien closed 4 years ago

ialarmedalien commented 4 years ago

Some updates to the stored queries, document schema, and added some tests and data to liven things up.

Schema changes:

ialarmedalien commented 4 years ago

Overall looks good and I don't have any adamant requests. I do think moving the djornl importer into a second module and wrapping it in a class are two extraneous layers. I also had some tangential thoughts about running importers, which may or may not affect your testing setup:

importers should be able to run without the user having access to the local data and without checking in the data to the repo, meaning they would be responsible for downloading the raw data over network We could use either blobstore or file cache server to store the data, and when we download the data, the importer should validate a checksum The RE API should check whether imports have run, and if not, then kick them off. This could be an explicit poke

A couple of thoughts / responses to your thoughts and responses: