Reorganize queries

[jayrbolton]

• Rename "views" to "stored queries"
• Move the AQL into the yaml key "query"
• Add "name" (query name) and "params" (json schema on query parameters) for each query
• Update test/validate.py to work with the above changes

[jayrbolton]

@MrCreosote I added AQL syntax checking, plus bind var validation using the arangodb query parsing endpoint. Turned out to be pretty easy and uncovered a couple bugs

Note on the @ws_ids bind var: this is a special bind var that is set by the RE API for every query of all workspaces the requester has access to. In AQL, if you have a bind var set, but it doesn't appear in the query, then an error gets thrown. However, we don't want to use this variable in all queries (eg. taxonomy). So the RE API will prepend the clause LET ws_ids = @ws_ids to prevent the error. To be consistent, we can just use ws_ids when we need to use that var.

[MrCreosote]

this is ready for re-review then?

[jayrbolton]

Ready for re review

On Mon, Jul 22, 2019 at 5:41 PM MrCreosote notifications@github.com wrote:

this is ready for re-review then?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kbase/relation_engine_spec/pull/67?email_source=notifications&email_token=ACCV47FIPR3XHWIOKJOZTEDQAZHVBA5CNFSM4IF5XFP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2RSIDQ#issuecomment-514008078, or mute the thread https://github.com/notifications/unsubscribe-auth/ACCV47DZU5W6MUR7E7JTBB3QAZHVBANCNFSM4IF5XFPQ .

[jayrbolton]

@MrCreosote I made some more updates, ready for re-review if you have time:

• Changed the names dicts to sets as suggested
• Moved some config into the environment / docker-compose. Makes a little more sense for that config to live there, but it doesn't need to be configurable for this repo.
• I updated many of requirements and default values for the stored query params based on what i think makes sense with the query. Not confident this is all backwards compatible so I'll have to manually test a bunch of things

For json schema default values, I'm going to add something like this in the RE API: https://python-jsonschema.readthedocs.io/en/stable/faq/

[MrCreosote]

Looks ok to me other than the question about the cached fn call. I didn't look at the stored queries though.