search

kbaskett248 / adafruit_macropad

45 stars 21 forks source link

Support configuration of MacroPad over a serial data connection #5

Open avi-perl opened 2 years ago

avi-perl commented 2 years ago

This PR adds support for reading data over the serial data port from the host computer. This data is used to configure the MacroPad and is available for use by apps.

At the time of creation, this feature is not quite ready. I look forward to your input!

Additional changes include support for a private apps folder where apps not intended for committing to git may be stored. When this private folder is not correctly configured, we fall back to using the default apps that are included with the project.

kbaskett248 commented 2 years ago

Right now this PR feels like it is going in a couple of different directions. In addition to serial data functionality, it's also introducing the private_apps concept. Are both required for this to work, or would it be possible to split this up? The private_apps functionality seems a bit simpler, and also kind of necessary for you and others to use this repo. Maybe we should tackle that part first?

Also, it looks like a lot of the reorganization changes are showing up again in this PR. Can you fix that by merging/rebasing on master?

Right now I'm just having a hard time figuring out how the different pieces are supposed to fit together.

avi-perl commented 2 years ago

pinned_apps

Agree.

Honestly, the trouble is that I'm working off the device as I go, and I actively use it all day. With that said, I'll submit some PRs slowly that are more focused with the goal of getting this one merge ready.

kbaskett248 commented 2 years ago

Agree.

Honestly, the trouble is that I'm working off the device as I go, and I actively use it all day. With that said, I'll submit some PRs slowly that are more focused with the goal of getting this one merge ready.

I wonder if there is some sort of tooling that might make this easier. I tend to do my development in a separate folder, and then copy the files over. I created an issue with some ideas to potentially reduce friction. Would love to hear if you have any thoughts there.