search

kbaum / heroku-database-backups

Heroku database backups and copies to S3
MIT License
99 stars 82 forks source link

Script Improvement and Instruction for Already Created App #5

Closed ibrahim12 closed 6 years ago

ibrahim12 commented 9 years ago

Hi,

Thanks for writing this fantastic script.

  1. I have added some instruction for those who already created the app without buildpack multi .
  2. It is not needed to download and build awscli. Currently it is failing on finding aws binary on /tmp after being installed. Also giving pip==1.4.1 requirement error as pip version is updated currently as 1.6.1 . So I have removed the aws local download portion and installed awscli via pip . Added this on the requirements.txt
  3. Add a flexibility to use DATABASE_URL directly in DATABASE variable. DATABASE_NAME is scrapped from Heroku for the former case.

Thanks.

kbaum commented 9 years ago

@ibrahim12 - We run our backups from a completely separate app from our database. I think it's a bit simpler this way. Separation of concerns. Not only that but you are then running your backups for free since you have no dynos running on this other project. If we agree this is a cleaner approach then it simplifies the setup as there are less branches in the instructions.