kbgg / qgis-stac-browser

Plugin for QGIS to browse and download assets from STAC APIs
Apache License 2.0
26 stars 9 forks source link

Assuming title is always available in collections #71

Open fredliporace opened 4 years ago

fredliporace commented 4 years ago

@kbgg congrats on this awesome project!

I'm tinkering with it to submit a PR to include the CBERS stac api server, and noticed that the browser assumes that title is always available for collections, more specifically here:

https://github.com/kbgg/qgis-stac-browser/blob/e94b70376160a77f8ddabf3514297302337d9ad8/controllers/query_dialog.py#L63

This breaks if no title is available. Since this field is not currently required it would be better to use id if title is not available. This is what I did in my fork,