i18n support - Githubissues

kbhff / eggplant

Eggplant is an open source web application that provides simple and flexible infrastructure for organizing food co-ops and other local community-driven projects.

http://eggplant.dk

28 stars 17 forks source link

i18n support #131

Closed benjaoming closed 8 years ago

benjaoming commented 8 years ago

This PR includes:

English msgid's
Transifex config, we're here btw: https://www.transifex.com/kbhff/eggplant/
Django settings updated for i18n
url patterns updated

coveralls commented 8 years ago

Coverage remained the same at 72.01% when pulling ecce7b8c94ab7e8c66355fc5acb96c6858c054c0 on benjaoming:i18n into 82dee0cd388724874afe491f30b6f67b37560d3b on kbhff:master.

benjaoming commented 8 years ago

Language chooser added:

screenshot from 2016-10-11 16-56-12

coveralls commented 8 years ago

Coverage increased (+0.2%) to 72.187% when pulling 9ee08e769ddee3573216f6646b15426952670133 on benjaoming:i18n into 82dee0cd388724874afe491f30b6f67b37560d3b on kbhff:master.

benjaoming commented 8 years ago

Any comments on this?

IMO it's fine to put all the .po and .mo files in the repo, otherwise we have to start using build commands for development and Heroku deployment.

coveralls commented 8 years ago

Coverage increased (+0.2%) to 72.187% when pulling ff0f600193bfc5952ebed2722994b4cf7f1182b6 on benjaoming:i18n into 82dee0cd388724874afe491f30b6f67b37560d3b on kbhff:master.

sepow commented 8 years ago

Did a quick scan, it looks good to me

benjaoming commented 8 years ago

@kraenhansen thanks for the comments, made the amendments, I dare merge this then :)

coveralls commented 8 years ago

Coverage increased (+0.2%) to 72.187% when pulling 8abfc431cd015c52a10de61501bbf3f1b126e273 on benjaoming:i18n into 82dee0cd388724874afe491f30b6f67b37560d3b on kbhff:master.