kbilsted / StatePrinter

Automating unit testing and ToString() coding
Apache License 2.0
93 stars 32 forks source link

Update to support multi-targeting #58

Closed conradmicallef closed 5 years ago

conradmicallef commented 5 years ago

The update essentially creates a multi-targeted version of the library Essentially only project files were modified and only 1 cs file was modified as the named properties are now in new project files.

Kindly consider for inclusion into your mainstream branch

the main advantages is that this essentially makes your library ready for .net core

kbilsted commented 5 years ago

Hi Conrad

Many thanks. At the moment the release to nuget is controlled by DeployToNuget.cmd I would think we need to do changes there as well. Is that something you can help with? Or maybe a different release process is in order?

conradmicallef commented 5 years ago

I have never published a package on nuget, however it seems to be as follows:

https://docs.microsoft.com/en-us/nuget/quickstart/create-and-publish-a-package-using-visual-studio

Possibly you might need to get a recent nuget.exe

When using visual studio PACK, the nupkg generated contains 2 dlls – I am using VS2017 (15.9.5) So seems visual studio handles everything and pssoibly no changes are required.

Sent from Mail for Windows 10

From: Kasper B. Graversen Sent: 09 January 2019 16:12 To: kbilsted/StatePrinter Cc: conradmicallef; Author Subject: Re: [kbilsted/StatePrinter] Update to support multi-targeting (#58)

Hi Conrad Many thanks. At the moment the release to nuget is controlled by DeployToNuget.cmd I would think we need to do changes there as well. Is that something you can help with? Or maybe a different release process is in order? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

harrybellamy commented 5 years ago

I don't think DeployToNuget.cmd will need to change as you can still use NuGet to push the packages. CreateNuget.cmd however will need to change - command dotnet pack <path to csproj> would build the package.

kbilsted commented 5 years ago

your code doesn't build.

kbilsted commented 5 years ago

I've upgraded to v.4.6.1 now

kbilsted commented 5 years ago

if you dont know how to do branching we can do a short screen share session and i can show you

conradmicallef commented 5 years ago

Its ok – do you need me to do a branch with my changes ? or you mean for the future ?

Sent from Mail for Windows 10

From: Kasper B. Graversen Sent: 21 January 2019 19:54 To: kbilsted/StatePrinter Cc: conradmicallef; Author Subject: Re: [kbilsted/StatePrinter] Update to support multi-targeting (#58)

if you dont know how to do branching we can do a short screen share session and i can show you — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

kbilsted commented 5 years ago

All PR. Including this one. If you pull from my master and start over then youll see a lot of cleaning up of the changes. Alternatively, you may do a git rebase -i head~6 and your commits around and get rid of the merge node.

finally this PR need the appropriate changes to the create ps1 so we can build a proper nuget with several targets