kbingham / libcamera

libcamera - Making complex cameras easy. This is a personal fork, please use the upstream repository at https://git.libcamera.org/libcamera/libcamera.git/
https://libcamera.org
Other
173 stars 69 forks source link

Pipeline handler writers guide - vivid pipeline handler not functional #87

Open VeruGromnicova opened 11 months ago

VeruGromnicova commented 11 months ago

Hello, I have few problems with guide for pipeline handler writers. The code always ends up with many errors. In every stage of coding - in the test parts and in the final stage, when the code should already be complete. One of the most frequently occurring errors in the output is this:

../src/libcamera/pipeline/vivid/[vivid.cpp:63:40:](http://vivid.cpp:63:40/) error: invalid use of incomplete type ‘class libcamera::Camera::Private’
   63 | class VividCameraData : public Camera::Private
      |                                        ^~~~~~~
In file included from ../include/libcamera/base/log.h:15,
                 from ../src/libcamera/pipeline/vivid/[vivid.cpp:1:](http://vivid.cpp:1/)
../include/libcamera/base/class.h:35:15: note: forward declaration of ‘class libcamera::Camera::Private’
   35 |         class Private;                                                  \
      |               ^~~~~~~
../include/libcamera/camera.h:116:9: note: in expansion of macro ‘LIBCAMERA_DECLARE_PRIVATE’
  116 |         LIBCAMERA_DECLARE_PRIVATE()
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~

Any clue what could this mean and how can I make it work? Thank you.

kbingham commented 11 months ago

Ah I'm sorry the guide likely needs updating.

Could you build the example from here and test please?

https://git.libcamera.org/libcamera/vivid.git/

VeruGromnicova commented 11 months ago

Thank you for the quick reply. I confirm that from the new source the build runs without any problems, thank you very much.