UI bug: Study is 'active' if confirmation is cancelled & 'inactive' if view all studies button is used.

[will-molloy]

Currently, if you click send invitation when viewing a single study the study status is set to 'active' immediately when it should wait for the user to click send invitation again on the confirmation pop-up.

Reproduce:

• Login as admin (admin:admin).
• Create a study.
• View the study.
• Click send invitation without confirming it.
• Notice the status is 'Active' and 'End Study' button appears when you have not yet confirmed sending the study invitation.
• Also, clicking 'Cancel' on the confirmation will not undo the status change yet invitation emails have not been sent out.

Fix: A simple fix is moving the code in the 'beginStudy()' function instudy-detail.component.ts into the 'confirmSend()' function in study-confirm-invitation.component.ts and deleting the call to 'beginStudy()' in study-detail.component.html.

Update: Related bug on view all study page, see below.

Acceptance:

• Clicking 'Send Invitation' on viewing a single study only changes the status after confirming.
• Clicking 'Send Invitation' on viewing a single study and canceling keeps the study inactive and no emails sent.
• Sending an invitation on viewing all studies changes the status after confirming.

@softeng-701 This requires moving existing code so a very-small issue.

[will-molloy]

@softeng-701 bump. Added screen shot and reproduce detail.

[softeng-701]

@wilmol APPROVED!

[will-molloy]

After the recent merges another bug has come up. The 'Send Invitation on the view all studies page doesn't update the status:

Screenshots of bug:

View all studies page:

After clicking 'Send Invitation':

After confirming:

Reproduce:

• Login as admin (admin:admin).
• Create a study.
• View all studies.
• Click send invitation and confirm it.
• Notice the status is 'Inactive' yet emails have been sent.

Fix: This 'Send Invitation' button is calling confirmSend() so the fix above should fix this at the same time (keep as very-small). Have updated acceptance criteria however.