search

kblincoe / QualOpt_SE701

2 stars 15 forks source link

Issue: Fix Twitter Sign-Up Registration Email Issue #107

Open st970703 opened 6 years ago

st970703 commented 6 years ago

This issue is related to Issue #24.

Upon registration, a registration email should be sent (as there is a message saying an email is sent). However, after signing in with Twitter and the registration email could not be sent. An IllegalArgumentException is thrown.

image

image

According to 'victorlian', this can be caused by the back-end not retrieving the email information of the Twitter account properly.

However, I have problems reproducing this issue since the database has already stored my Twitter account information and I don't and won't receive the Twitter registration emails anymore.

This issue should be a small issue as it only affects the first the user tries to sign in using their Twitter account. This issue doesn't affect the functionality of Twitter sign-in. The user can still use QualOpt after signing in with his/her Twitter account, without receiving the registration email. @softeng-701

victorlian commented 6 years ago

Thanks, once this issue and #103 are both approved, I'll approve the change in #24 and that can be merged.

softeng-701 commented 6 years ago

@st970703 APPROVED!

st970703 commented 6 years ago

Hey, I will pick this issue up. I don't think I can fix the fact that the Twitter API cannot retrieve email addresses, but I can solve the exception caused by the 'to email address' is null.