kblincoe / QualOpt_SE701

2 stars 15 forks source link

Use environment variables for Facebook secrets #121

Closed nateeo closed 6 years ago

nateeo commented 6 years ago

Addresses the secret keys issue for #22

@st970703 @crat019 I propose simply replacing the getter for the keys with a System.getenv call. This would mean providing secrets as environment variables on the application host. If you think this is fine, I can also remove the old environment code.

Also we should probably add an option for setting these variables in the bash script as mentioned by @TheGuardianWolf

nateeo commented 6 years ago

@jsoulsby @Jcen902 ready for review

Jcen902 commented 6 years ago

Good idea. Good to go

nateeo commented 6 years ago

@softeng-701 ready to merge

softeng-701 commented 6 years ago

@Nateeo Please resolve the conflicts!

nateeo commented 6 years ago

@softeng-701 done!