kblincoe / QualOpt_SE701

2 stars 15 forks source link

Preset date and time for sending invitation emails #126

Closed pulkitkalra closed 6 years ago

pulkitkalra commented 6 years ago

This pull request completes #26.

The feature added here is the ability to preset a date and time to send invitation emails. User specifies if they want to send emails immediately or at preset time. This preset time is used to determine the delay in sending emails and then the invitation job is registered within the scheduler.

image

The emails are scheduled using Quartz.

Manual Testing in development

Input Validation

Dependencies

pulkitkalra commented 6 years ago

@st970703 @victorlian please review thanks :)

softeng-701 commented 6 years ago

@pulkitkalra Resolve conflicts, please!

victorlian commented 6 years ago

Also lots of merge conflicts for you :( Please let me know when you finish these so I can do a dynamic review :)

will-molloy commented 6 years ago

Can you run StudyResource sendStudy test.

pulkitkalra commented 6 years ago

@wilmol ahhh thank you for pointing that out, looks like I missed that test. The test was failing because the post request was sending a study object but now needs to send an invitation object instead. This has been fixed now :)

pulkitkalra commented 6 years ago

@softeng-701 ready to be merged :)

softeng-701 commented 6 years ago

@pulkitkalra Squash please!

softeng-701 commented 6 years ago

@pulkitkalra conflicts arose again, please check! thanks!

pulkitkalra commented 6 years ago

@softeng-701 resolved and squashed. Ready to merge :)

pulkitkalra commented 6 years ago

@softeng-701 bump. This is ready to go