Issue #120 Clear input box after updating password

[umih874]

NOTE

While solving this issue some bugs related to issue #27 were discovered. Since the pull request, #66 has already been merged and team Veovo worked on issue #27 we decide to add fixes for that issue in this pull request.

Changes made for the issue #27

This is also referenced in #66 which explains how to test and validate the implemented functionality. The current password field was bounded to new password field so whenever there was an error in new password field the error for current password would be displayed. The bonding issue was solved and so that error for each field are only associated and triggered by the faulty field. Further changes were made to limit the number of characters the user can input (i.e. min 4 and max 50) identical to the property of the other input boxes.

Changes made for this issue #120

The additional function was added to the component file to clear the input fields from the entered input once the user attempts to log in. This is done by simply writing null to the input box value. The issue of the unwanted message showing described in #120 (in image 4) was resolved by adding boolean value that will block them being displayed when the user tries to log in. The blocking will stop once the user tries to input new text.

Testing

• Try to change the password with an invalid and/or valid current password and check if the input boxes and the messages "Your current password is required." have cleared upon error or success message shows up.
• Test if the functionality implemented does not affect any other functionalities.

Image evidence

Prior to password change

After changing the password

[umih874]

@zaclochhead @sidpartha1 please review changes

[zaclochhead]

Functionality is working as stated in the pull request. LGTM!

[JoeHorvath]

Just a heads up, my issue #4, which will be merged soon, involves moving the password page to settings so will no doubt cause some conflicts with yours. Basically you will have to move your password.component html and ts changes to settings.component html and ts. It shouldn't be too hard.

[umih874]

Is there a way you can pull my changes and then move code around? That way we shouldn't get any merge conflicts?

[JoeHorvath]

I think it will be easier if you merge your changes as you understand them better than me.

[umih874]

I had a look at it. This issue is depended on the issue #27 PR #66 which has already been merged. So I think that you will be moving those to a different component anyways, right? If I move these changes to a different component than this will cause an error because these changes are depended on those is #66. I still think it is easier for you to pull my changes since you won't get any merge conflicts. What is the best way of doing this? @softeng-701?

[JoeHorvath]

My branch is already conflict free with the merged changes as they were submitted before my request. Those dependencies should not be affected as long as you merge your branch correctly.

[softeng-701]

Squash & review please~

[umih874]

@softeng-701 I have tried squashing my commits but it added all these commits when I pulled from the kelly's fork. I can't squash these now. What should I do?

[umih874]

@softeng-701 Should be all good now