The upstream master branch is failing unit tests

[Karim-C]

The most recent pull requests which were merged in don't pass the unit tests.

To reproduce this issue: 1) Pull the latest upstream changes 2) In the QualOpt_SE701 folder run .\mvnw clean test to run the unit tests

The output will look like this:

Tests run: 193, Failures: 0, Errors: 180, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 07:23 min
[INFO] Finished at: 2018-03-25T13:06:09+13:00
[INFO] Final Memory: 44M/480M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test (default-test) on project qual-opt: There are test failures.
[ERROR]
[ERROR] Please refer to C:\Users\KBM28\git-testing\QualOpt_SE701\target\surefire-reports for the individual test results.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

The following warning and exception that was in the output seems to be the casue of the issue:

2018-03-25 13:22:27.040  WARN 9472 --- [           main] o.s.w.c.s.GenericWebApplicationContext   : Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'entityManagerFactory' defined in class path resource [org/springframework/boot/autoconfigure/orm/jpa/HibernateJpaAutoConfiguration.class]: Invocation of init method failed; nested exception is javax.persistence.PersistenceException: [PersistenceUnit: default] Unable to build Hibernate SessionFactory
2018-03-25 13:22:27.101 ERROR 9472 --- [           main] o.s.boot.SpringApplication               : Application startup failed

org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'entityManagerFactory' defined in class path resource [org/springframework/boot/autoconfigure/orm/jpa/HibernateJpaAutoConfiguration.class]: Invocation of init method failed; nested exception is javax.persistence.PersistenceException: [PersistenceUnit: default] Unable to build Hibernate SessionFactory

@softeng-701 Estimating the size of this issue is difficult because the majority of the effort fixing this issue will likely be identifying the root cause of the issue. I think the problem is likely stemming from a small error in the code, so I believe this issue should be labelled very-small.

[will-molloy]

131 fixes it afaik

[softeng-701]

@Karim-C @wilmol shall I close this?

[xavier630]

Moving my issue here since it's easier to track:

Master is currently not building due to compilation errors in one of the test classes.

@TheGuardianWolf Spotted the issue and has resolved it in this commit: cf2ac08

The file causing the errors is this file: StudyResourceIntTest.java

I estimate that this issue is an extra small.

[TheGuardianWolf]

We really need a CI tool for this, then we won't have to track these

If you're down on issues, you could probably do this, it takes about 5 minutes. I have the docker container setups if anyone wants them that could help.

[xavier630]

Raise an issue to add a CI tool? :P

[TheGuardianWolf]

Our team has done nearly 2x the suggested issue amounts, not really keen on adding more at this current point in time xD

[xavier630]

I'm addressing the above issue now:

Moving my issue here since it's easier to track:

Master is currently not building due to compilation errors in one of the test classes.

@TheGuardianWolf Spotted the issue and has resolved it in this commit:
cf2ac08

The file causing the errors is this file:
StudyResourceIntTest.java

I estimate that this issue is an extra small.

@softeng-701 Can I please get approval? I've started working on it anyway since it's affecting upstream master builds.

[will-molloy]

@softeng-701 The handout wants us to create issues before PRs so I think this is a valid issue.

[Karim-C]

Adding a CI tool is a good idea, Xavier. I raised an issue.

[TheGuardianWolf]

I believe this can be closed now?