kblincoe / QualOpt_SE701

2 stars 15 forks source link

#41 More filters for finding participants #150

Closed oliver-allen closed 2 years ago

oliver-allen commented 6 years ago

This pull request closes #41

There are 3 new properties to filter a participant by:

The Participant class now has these properties as fields and can be created through the GitHub API and manually creating a participant.

The Participant page includes extra fields for filtering participants by these properties. They are also reflected in the table of participants screen shot 2018-03-28 at 5 14 02 pm

The viewing and editing pages of Participants also reflect these new properties screen shot 2018-03-28 at 5 20 08 pm screen shot 2018-03-28 at 5 20 24 pm

Related Issues Complete

Limit quantitative participant filtering #117 limited the range for the number of contributions and number of repositories. The new followers and following filters are also limited to the range from 0 - max value

Tests

The unit tests relating to participants have been updated to test the new Participant

oliver-allen commented 6 years ago

This will effects some of the open issues:

34 Link filtering participants to studies

136 Adding unit tests for GitHubResource REST controller and refactoring for Testability

149 Bug: Only allow positive numeric values of a participant

oliver-allen commented 6 years ago

Good splotting. It seems to work even with that error. Fixed and tested.

oliver-allen commented 6 years ago

@softeng-701 Ready to merge. It has been reviewed and squashed as much as I can