search

kblincoe / QualOpt_SE701

2 stars 15 forks source link

Status of emails #36

Open softeng-701 opened 6 years ago

softeng-701 commented 6 years ago

Currently, if an email is sent to an incorrect email address there is no way for the user to know this from within QualOpt. It would be useful, after sending the emails, to be able to see which ones were successful and which bounced back.

will-molloy commented 6 years ago

Will work on this soon

will-molloy commented 6 years ago

Currently 'Send Invitation' button does nothing. Need to fix this first.

will-molloy commented 6 years ago

Blocked until #76 is merged.

pulkitkalra commented 6 years ago

@wilmol this shouldn't be blocked by #76 anymore, but I'm wondering if #26 (my issue) would block this. You would want the status to reflect something like: "Email Sent!" or "Email Scheduled to be sent in xx hours".

Unfortunately, #26 is taking much longer than I anticipated, but hopefully this won't be blocked for long.

will-molloy commented 6 years ago

@pulkitkalra I have the backend service now retrieving the bounced email addresses (the hard part).

For the frontend I plan for a pop-up showing 'Failed to send study ... to ...' with the bounced addresses and a link to view that study. This pop-up will only show if it fails to send (I think its redundant to show successfully sent?).

So in regards to your issue this would mean pop-ups when the user might be doing something else. Do you think this is fine?

will-molloy commented 6 years ago

@pulkitkalra For the backend I've modified the StudyService class from #76 and its specific to gmail at the moment so let me know if you need to change that class.

pulkitkalra commented 6 years ago

@wilmol actually, I just realised that there is now a pop-up prompt asking the user to confirm send when you press 'send invitation'. That can be used to confirm to the user that the email will instead be sent in xx hours (if they preset a time). So yeah, don't worry about the successfully sent prompt :)

I will be changing StudyService, but your PR will probably come in before I finish my issue so there might be a conflict or two to resolve.