Closed JGud007 closed 6 years ago
Just thinking further about this @JGud007 , why did you decide to separate the popups? How does that solve the input issue?
@FMcIntosh does the original comment make more sense now? pasted the wrong issues text sorry.
@JGud007 Ok that makes more sense now. My concern would be that we have to maintain two components that do exactly the same thing apart from the title. For example for issue #1 the change would have to be made in two places. Did you consider making the title conditional?
@FMcIntosh updated pull request to make title conditional as suggested, so now there is only one popup that needs to be maintained
Looks good
@softeng-701 all reviewed by my team 👍
This is to fix issue #11 stating "Currently, the pop-up section for creating a study is identical to the section for editing a study. This is correct except the title is currently ‘Create or edit a study’. This should be changed to be ‘Create Study’ if a new study is being made or ‘Edit Study’ if an already created study is being edited."
This was fixed by creating separate creation and editing popups for studies.