search

kblincoe / QualOpt_SE701

2 stars 15 forks source link

Helper method `this.isNew()` in create/edit popup dialog #58

Open frederickfogerty opened 6 years ago

frederickfogerty commented 6 years ago

The logic to check whether the popup dialog is creating a new study or editing an existing study is currently used in one place, but after the merge of #52, it will be used in two places. I would like to refactor this into a new method this.isNew() to keep it DRY.

Currently used here: https://github.com/JGud007/QualOpt_SE701/blob/master/src/main/webapp/app/entities/study/study-dialog.component.ts#L75

frederickfogerty commented 6 years ago

@softeng-701

softeng-701 commented 6 years ago

@frederickfogerty Kindly mention size of the issue in all your future requests!

frederickfogerty commented 6 years ago

@softeng-701 sure, will do in the future! I think this is very-small.

softeng-701 commented 6 years ago

@frederickfogerty Awesome! APPROVED!

frederickfogerty commented 6 years ago

Claiming