search

kblincoe / QualOpt_SE701

2 stars 15 forks source link

#35 New E-mail option #84

Closed Jcen902 closed 6 years ago

Jcen902 commented 6 years ago

A new feature for #35.

Change:

  1. Add a new Set under Study class, to save a list of email addresses who have receive an e-mail.
  2. A new table is created in the database, for the Set I mention above.
  3. Some liquibase configure files have change to adapt for change 1(src/main/resources/config/liquibase/changelog/20170806142424_added_entity_constraints_Study.xml and src/main/resources/config/liquibase/changelog/20170806142424_added_entity_Study.xml).
  4. Change the the HTML for study detail page to add a new button for send email to new participants only
Jcen902 commented 6 years ago

@Nateeo @jsoulsby

softeng-701 commented 6 years ago

@jsoulsby @Jcen902 @Nateeo URGENT! Kindly review and approve the changes, I still see some open discussions, thanks!

nateeo commented 6 years ago

@softeng-701 Waiting on @Jcen902 to push changes resulting from the code reviews above

softeng-701 commented 6 years ago

@Jcen902 resolve conflicts please! Thank you!

Jcen902 commented 6 years ago

As I learn more about how this APP works, I am not happy about my last solution, change direction and start over again.

nateeo commented 6 years ago

@Jcen902 Can you close this issue for now then? It's blocking the rest of the pull requests

Jcen902 commented 6 years ago

@Nateeo @jsoulsby Nearly Rewrote everything, please check. I test it with real email, looks like it is working.

Jcen902 commented 6 years ago

@jsoulsby i think we should keep that log.debug, as that will be easier for other developers to understand what the APP is going on in the backend

Jcen902 commented 6 years ago

@softeng-701 It is ready for merge

softeng-701 commented 6 years ago

@Jcen902 @Nateeo @jsoulsby Please squash the commits!

Jcen902 commented 6 years ago

@softeng-701 Squash all the way to the first commit?

nateeo commented 6 years ago

@Jcen902 yes, so that your PR only has 1 commit

softeng-701 commented 6 years ago

@Jcen902 Resolve the conflicts please!

Jcen902 commented 6 years ago

@kblincoe Can I open a new PR for this issue instead squashing so many commits?

kblincoe commented 6 years ago

If that will help, you can close this pull request and open a new one (it will need to be approved again by your teammates). You will still need to squash the changes into a single commit.