kblincoe / VisualGit_SE701_1

0 stars 0 forks source link

Closes #61 by signing commits with the users email instead of their password #180

Closed j-x-huang closed 6 years ago

j-x-huang commented 6 years ago

Overview

The author of commits made via VisualGit is shown as the user's password because the name is extracted from the signature of the commit. Currently, the signature is signed with the user's password instead of their email. A git signature should take the form of (username, email) as documented here.

Solution

My fix for this issue is to create the Git signature with the user's email instead of their password. The user's email can be the user's login (if they log in using their email) or it is obtained by using Octonode (the email must be publicly viewable though).

Further Issues

Currently, the solution makes a dummy email address if an email address cannot be found. Commits and pushes will still work with this. However, in the future, it should use an email address that is actually linked to the user's GitHub profile.