search

kblincoe / VisualGit_SE701_2

1 stars 0 forks source link

Use sass compiler instead of changing css file directly #101

Closed chaejj closed 6 years ago

chaejj commented 6 years ago

The project README file specified that style sheets are written in Sass (.scss files). However, the sass file had been left untouched and instead css files had been directly modified before VisualGit_SE701_2 group started working on it. This lead to confusion as to which file to modify.

Therefore, it will be a good idea to make development workflow consistent to what is written in README. To do that, one of these needs to be done: Option 1) Remove any reference to Sass in the code including readme documentation Option 2) Update stylesheets/styles.scss file to reflect everything that has been added to css file directly, update readme instruction for using sass and start using sass.

As the use of Sass provides syntax advancements to css stylesheets, option 2 is recommended.

@softeng-701

softeng-701 commented 6 years ago

@chaejj Approved

bpar476 commented 6 years ago

I'm being blocked by the difficulty of working through this so I will implement this and do option 2.

bpar476 commented 6 years ago

PR created #151