search

kblincoe / VisualGit_SE701_2

1 stars 0 forks source link

[INVESTIGATION] Graphs not showing #116

Closed bridgethall closed 6 years ago

bridgethall commented 6 years ago

Prior to pull request #98 a commit has broken the graphs displaying. This feature was previously working and now does not show graphs at all.

Investigation is needed to find the last working commit so that this issue can be fixed by the relevant people.

this is a medium issue

@softeng-701

whydah12 commented 6 years ago

Will perform a bisect and find out when the graph stopped drawing

whydah12 commented 6 years ago

Completed Bisect. The commit that breaks the graph drawing is: b48529aa5ebdac1ec17bf32d95f1863a46ee8652 Fix issue of panel display on checkbox click @luke-tudor

Here is the log of what I did: bisect_log.txt

whydah12 commented 6 years ago

Note that @sundriedtofu 's fix for issue #114 has not yet been pulled into master. To fix this run npm install machine-id-node --save

softeng-701 commented 6 years ago

@brmhall1 Approved

softeng-701 commented 6 years ago

@brmhall1 @whydah12 This seems like a small issue without the fix... Can this now be closed?

whydah12 commented 6 years ago

Yes, this can be closed