kblincoe / VisualGit_SE701_2

1 stars 0 forks source link

[Feature] Move colour changing button to right of sign in/out button and change appearance to match other button appearances #138

Open MGriffith37 opened 6 years ago

MGriffith37 commented 6 years ago

Currently, with the colour changing button located to the left of the sign in/out button, the colour button overlaps with the credential inputs when the user goes to sign in. As seen below:

Without credential inputs expanded:

screen shot 2018-03-23 at 1 48 10 pm

With credential inputs extended:

screen shot 2018-03-23 at 12 38 20 pm

Note how the colour button is covered by the password input and the Sign In button

This clutters the navbar unnecessarily as well as being an example of poor usability (user cannot change colour theme while signing in).

I propose to move the colour button to the right of the sign in button so that the overlapping issue is fixed. It also lends to, what I believe to be, a more intuitive interface as functionality (logging in/out) is positioned closer to the left side of the interface where all of the git functionality is located. And the aesthetic functionality (colour theme) is abstracted to the right, more distant from the core functionality.

I also believe the current colour theme button sticks out as it doesn't match the styling of the other buttons. I propose to alter the button to match the styling of the sign out button (rounded edges). This lends to a more consistent aesthetic. See an example of my proposal below:

screen shot 2018-03-23 at 12 38 33 pm

I propose this to be a small issue. Only the styling and position of the button needs to be modified, which can be modified in the stylesheets.

@softeng-701

softeng-701 commented 6 years ago

@MGriffith37 Approved