search

kblincoe / VisualGit_SE701_2

1 stars 0 forks source link

[Issue] Remove Non-GitHub-User Functionality #153

Closed tmeyer-smith closed 6 years ago

tmeyer-smith commented 6 years ago

At the moment you are able to access VisualGit without being logged into GitHub, via the blue button on the main screen below.

image

This functionality seems to exist for the development process of VisualGit. However, now that the app has significantly progressed and there is the ability to retain your login credentials, I propose it be removed.

There are errors associated with using the app without being logged in as seen in #102. Any trace of using the app without authentication including the home screen and when committing and cloning from repositories should be removed. This job needs to be thorough otherwise issues like #139 will remain.

tmeyer-smith commented 6 years ago

@softeng-701 I reckon this is a small issue as it only requires removing code but a thorough job needs to be done to make sure there are no affected dependencies.

softeng-701 commented 6 years ago

@tmeyer-smith you don't think its worth keeping for using git locally?

tmeyer-smith commented 6 years ago

@softeng-701 I agree it is worth keeping. It just needs more work. I will close this issue and create a different one