kblincoe / VisualGit_SE701_2

1 stars 0 forks source link

[Issue #32] Add text editor inside application #179

Closed andystewart12 closed 6 years ago

andystewart12 commented 6 years ago

When comparing the differences between the files in your local repository and in the remote repository, you can now open up a text editor that can be used to edit the file from within the application.

Adding this feature involved restructuring the existing differences panel to give it the 'Edit file' button, as well as structuring and styling the text editor panel. The implementation of the transitions between the two panels was achieved through setting 'on click' listeners on the buttons in the panels, which are calls to functions that change the sizes of the panels or add/remove inner HTML to/from different HTML elements. The save button also has a listener on the file's text area, so that the button can become enabled when changes to the text area are detected. When the text editor panel is closed, the differences panel is reopened showing the newly saved changes to the file. Finally, I had allow for the background colour of the text editor panel to be affected by the colour theme in the same way that the differences panel is.

softeng-701 commented 6 years ago

@andystewart12 Please squash your commits before the deadline. Make sure all group members have reviewed this

andystewart12 commented 6 years ago

@softeng-701 I have squashed the commits. There were merge conflicts so I resolved them in a new branch and made a new pull request (https://github.com/kblincoe/VisualGit_SE701_2/pull/184). There are only two people in my group, just myself and Tim Meyer-Smith.

softeng-701 commented 6 years ago

@andystewart12 So this PR can be closed?

andystewart12 commented 6 years ago

@softeng-701 yes it can