kblincoe / VisualGit_SE701_2

1 stars 0 forks source link

[Issue #32] Add text editor inside application #184

Closed andystewart12 closed 6 years ago

andystewart12 commented 6 years ago

When comparing the differences between the files in your local repository and in the remote repository, you can now open up a text editor that can be used to edit the file from within the application.

Adding this feature involved restructuring the existing differences panel to give it the 'Edit file' button, as well as structuring and styling the text editor panel. The implementation of the transitions between the two panels was achieved through setting 'on click' listeners on the buttons in the panels, which are calls to functions that change the sizes of the panels or add/remove inner HTML to/from different HTML elements. The save button also has a listener on the file's text area, so that the button can become enabled when changes to the text area are detected. When the text editor panel is closed, the differences panel is reopened showing the newly saved changes to the file. Finally, I had allow for the background colour of the text editor panel to be affected by the colour theme in the same way that the differences panel is.

andystewart12 commented 6 years ago

@softeng-701 I have squashed the commits from the original pull request and resolved conflicts. There are only two people in my group (just me and Tim Meyer-Smith) so the change is good to go and is ready to be merged

softeng-701 commented 6 years ago

@andystewart12 Looks good! Will merge after the deadline

softeng-701 commented 6 years ago

@andystewart12 Please resolve conflicts, thanks

andystewart12 commented 6 years ago

@softeng-701 Done, resolved conflicts.