search

kblincoe / VisualGit_SE701_2

1 stars 0 forks source link

GitHub profile pictures on nodes #27

Open softeng-701 opened 6 years ago

softeng-701 commented 6 years ago

Currently, only the first letter of GitHub users' names appears on the nodes. It would be more useful to have their GitHub profile pictures so they can be more easily identified.

andystewart12 commented 6 years ago

I'll work on this one. Group 39: Cyril

andystewart12 commented 6 years ago

I am giving up working on this issue. I have written a function in images.ts that uses the node package GitHub Username to retrieve a user's username from their email address, and then the username can be used to get a link to the user's avatar. The function is not called anywhere so it will not affect anything else. This change currently only in my forked repository, in its own branch. The reason this has not been completed is because there are inconsistencies in the data received about the commit authors and we can not always rely on there being an email address. If this is ever resolved and we can reliably get the author's email address for every commit then the function should be able to be used.