search

kblincoe / VisualGit_SE701_2

1 stars 0 forks source link

Password visible in Author field after auto-resize of branch graph #44

Open bridgethall opened 6 years ago

bridgethall commented 6 years ago

Steps to reproduce:

  1. Go to an existing local repo
  2. Open a branch
  3. Zoom/resize on branch diagram until it auto-resizes to vertically fill the screen
  4. Hover mouse over a commit bubble, you will be able to see a pop-up with "Author: "password"

password_showing

@softeng-701 this is a medium issue

bridgethall commented 6 years ago

@kblincoe

kblincoe commented 6 years ago

OK approved

bridgethall commented 6 years ago

For a bit of further info on this issue: Within the authenticate.ts the function Git.Cred.userpassPlaintextNew had the username and password fields switched. This seems to have been fixed by another commit.