Migrate from deprecated typings to npm @types

[liamtbrand]

Description

Typings is the old way of managing typescript definitions. The new way of managing these definitions is through npm @types.

Also see https://github.com/typings/typings.

We should migrate and remove the files associated with the old way as they are unnecessary clutter in our setup.

Related to #113.

Acceptance Criteria

• Remove typings from package.json
• Remove typings.json and associated files
• Include required @types for dependencies
• Everything works as expected (nothing breaks)

[nathan-cairns]

Approved!

[swimuel]

Approved

[swimuel]

This issue is also important for security reasons as outlined in the screenshot above.

[swimuel]

@liamtbrand do you think it's worth merging this issue with #139 ? both are pretty small issues and related to vulnerabilities but that doesn't seem like the intention of this ticket, just a byproduct.

[liamtbrand]

I think it's fine to have two tickets for this. Like you pointed out this one fixes the vulnerabilities you mention in #139 as a consequence. I still think it's good to have separate changes for each dependency that we change.

[bcox280]

Related to #149

[swimuel]

Is there any progress on this issue in terms of approval? I think as it is causing a high risk vulnerability we should try and fix this before deadline.

[rmberriman]

Approved! Added a Small label - but feel free to change if you think it should be a Medium

[liamtbrand]

Small is probably fine, it's hard to say because it would also involve understanding how npm @types works and then making sure nothing is broken by the change. That might be some work I'm not sure.