Add button for creating new user in VisualGit header

cyrus-raitava commented 5 years ago

Related Issue/Keyword: Resolves #9

Description: This PR will add the functionality of being able to create a new account in GitHub, once the user is within the VisualGit window - that is, once they are past have 'Signed In', or clicked 'Continue without Sign In'.

Currently, a user may choose to 'Continue without Sign In', to use the application; at this point, once in the application, they are not able to create an account within Github; something that one might expect a new user to want to do.

Tests are not yet implemented, due to a lack of available testing framework. UI Testing can be done by the reviewer of this PR.

See screenshots of button, and follow-up window, here:

[x] Latest master merged/rebased into your feature branch
[ ] Tests covering all changes
[x] Meets the projects coding conventions
[x] No out of scope changes
[x] @Mentioned any relevant team members
[x] Included a relevant gif (search here for inspiration)

encryptededdy commented 5 years ago

Not the reviewer for this PR but would love to see what the GUI actually looks like; can we get some screenshots in the original PR description? ^_^

cyrus-raitava commented 5 years ago

@Ravid12 given the introduction of issue #159 , perhaps it would be best if this PR and it's related issue were closed. What are your thoughts on this?

cyrus-raitava commented 5 years ago

@Ravid12 will move to close this and its related issue now. Any follow-up discussions can occur within the follow-up issue, #159.

kblincoe / VisualGit_SE701_2019_1

Add button for creating new user in VisualGit header #131