Tool should not allow users to input invalid branch names

[Ravid12]

Description

On a local repository, if a user tries to create a new branch using the GUI, they can input branch names containing spaces, and will not warn users of an error.

I.e. the above image shows the terminal "accepting" the command git branch new branch with space

However, branch names are not allowed to contain spaces, and the application should warn users if they attempt to create a branch with a space in the name.

Steps to Reproduce

1. Open the application by either logging in or continuing without sign in.
2. Open a local repository.
3. Create a new branch by clicking the drop down with the current branch name:
4. Enter an invalid branch name. eg, a name with a space character in it
5. Click the "Ok" button

The application will accept any name (even a blank input), and it will appear to have created the branch, without showing any errors.

Acceptance Criteria

• Users should not be allowed to create branches with invalid branch names. according to this article
  • Have a path component that begins with "."
  • Have a double dot "…"
  • Have an ASCII control character, "~", "^", ":" or " ", anywhere
  • End with a "/"
  • End with ".lock"
  • Contain a "\"
• "Ok" button should be disabled out until the branch name in the text field is valid

[joel-clarke]

Approved. Would this fix also include attempting to create a branch with an empty name? Pretty sure it has the same effect.

[Jess-Alcantara]

Approved - possibly list invalid branch names in the acceptance criteria

[Ravid12]

@joel-clarke Yup, @Jess-Alcantara made a great suggestion! - see acceptance criteria

[swimuel]

Approved