Closes #17 - Add line numbers to viewing code changes

Jess-Alcantara commented 5 years ago

Issue

Closes #17

Description

Added line number for viewing code changes. View changes by opening a repository and selecting a file to view differences made locally.

Design Decisions

Decided to only show new line numbers so that finding where they made the changes are easier to find. Deleted lines, i.e. those without line numbers, display a "-" instead of a number. Added lines show with the new line number. NOTE: modifications to existing lines currently show as a deletion then addition

Tests

No automated tests yet as the test suite has not been set up. Manual tests: select a file and view if...

[x] Correct new line numbers show before a change
[x] Correct new line numbers show after a deletion
[x] Correct new line numbers show after a addition
[x] Correct new line numbers show after a modification (shows a proper deletion and addition)
[x] Correct new line number shows on a addition
[x] "-" shows on a deletion

[x] Latest master merged/rebased into your feature branch
[ ] Tests covering all changes
[x] Meets the projects coding conventions
[x] No out of scope changes
[x] @Mentioned any relevant team members
[x] Included a relevant gif (search here for inspiration)

Jess-Alcantara commented 5 years ago

Thanks for having a look! I just had a try at reproducing the issue you've said and it seems to happen when you make an addition or deletion to the end of the file. It should not be saying the stuff after line 288, will look at providing checks to remove it.

Jess-Alcantara commented 5 years ago

Also realised that spaces between the line number and code should be consistent, so will work on a fix for that too.

Jess-Alcantara commented 5 years ago

Rebased off master and pushed my new fixes - not sure why these other commits showed up though or why I had to merge my own branch into my own branch. Took a while to figure out how to work with the callbacks but it now:

Has consistent spaces between the line number and the lines of code
Does not add the extra lines when you make changes to the end of a file

kblincoe / VisualGit_SE701_2019_1