search

kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

Setup Testing for Angular Components #153

Closed KelseyRM closed 5 years ago

KelseyRM commented 5 years ago

Testing is setup for non-angular typescript files, but not for Angular components yet. Investigation into Angular Testbed will be needed due to the version we are using.

Acceptance Criteria Testing via Jasmine and Karma of Angular Component files needs to be setup.

bcox280 commented 5 years ago

This is absolutely necessary for testing specific functionality within the app, approved

nathan-cairns commented 5 years ago

V important. Approved!

hhagenson28 commented 5 years ago

Agree with above comments, approved!

KelseyRM commented 5 years ago

From what I can tell the Angular version we are running doesn't support the Angular TestBed and surrounding functionality, and there is a very good chance that #149 and ensuing implementations will be the only way to remedy this. I'm going to keep digging and see if there is a way around this but even just by looking at @angular/core/testing there is no TestBed where there should be.

KelseyRM commented 5 years ago

Due to time constraints and the massive reworking that would be required for this, we will no longer be setting this up. Manual testing of each PR will be the main method for testing the app and its components.