kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

Fixes#64 auto scrolling to git command console #161

Closed emipeanz closed 5 years ago

emipeanz commented 5 years ago

Related Issue/Keyword: Closes #64

Description: This is probably one of the chillest pull request you'll do, it just adds/fixes the functionality for the git console on the home screen to scroll to the latest command used and changes a grand total of one line of code. This component cant really be tested as it is basically just a UI thing.

emipeanz commented 5 years ago

Looks good and is working as expected! Just wondering if its possible to automatically move the scroll bar to the bottom so that it scrolls down to the latest information as it is added to the console, as stated in the original issue?

I took that "console auto-scrolled to the most recent command" meant that the latest command was always on the bottom. Are you thinking of when a new git command is added (ie. clicked pull and the git pull command pops up down the bottom) the thing animates and scrolls to the ground????

hhagenson28 commented 5 years ago

Yea, I thought it meant that it auto-scrolls when a new command is added. So yes, if its possible, it would pretty useful for the user to always see the latest information in the console, if it scrolled to the bottom with each new addition.

emipeanz commented 5 years ago

Its meant to just sit on the bottom of the console ie. sitting on the latest command always 😬 is it not doing that? Cause it does on my local