Fixes #145 - Text field cut off when entering a branch

kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

Fixes #145 - Text field cut off when entering a branch #166

Closed twchen97 closed 5 years ago

twchen97 commented 5 years ago

Related Issue/Keyword: Closes #145

Description: Added margins around the text field for entering a branch in the collapsable menu as previously 'OK' button and text were cut off.

[x] Latest master merged/rebased into your feature branch
[ ] Tests covering all changes - no tests as UI change only
[x] Meets the projects coding conventions
[x] No out of scope changes
[ ] @Mentioned any relevant team members
[x] Included a relevant gif (search here for inspiration)

joel-clarke commented 5 years ago

I just wanted to check, did choosing/creating a branch ever work from that collapsed menu? I checked on your branch and mine, and they both didn't work so this might just be another issue. Your fix for the text field looks good, so if that's the case I'll write up a new issue and complete the review.

twchen97 commented 5 years ago

The functionality of choosing/creating a branch should be a seperate issue since I don't think it's ever been working from the collapsed menu. This fix was just for the UI :)