kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

Fix #16 - Error popup on creating new branch when no repo opened #168

Closed joel-clarke closed 5 years ago

joel-clarke commented 5 years ago

Related Issue/Keyword: Closes #16

Description: Before the change you were able to try create a new branch when there were no repo open. Now when attempting to create a branch, if there's no repo opened an error message will be displayed.

Tests No automated tests yet as the test suite has not been set up.

Manual tests With no repo open:

With a repo open:

emipeanz commented 5 years ago

Can confirm trying to create repo creates pop up 👍 And when I'm in repo, can create branch 👍 However, when I make said branch, then try switching back to another branch, I cannot seem to do that. Is this issue present in your local version?????

joel-clarke commented 5 years ago

Yup, I am on Windows. I updated the branch to the most recent version, the changed functionality seems to be working as expected for me and I can change branches. @lukethompsxn if you could retest the change that'd be great!

emipeanz commented 5 years ago

Yup, I can change branches, not sure what was going on there