kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

Closes #59 - Add git functions to tool bar #173

Closed nathan-cairns closed 5 years ago

nathan-cairns commented 5 years ago

Related Issue/Keyword: Closes #59

Description: Basically just added the git functionality from the header to the toolbar. This includes:

These options are in the toolbar under Tools > Git

Testing To test this just have a click around and see the functionality of clicking the corresponding buttons also works for the items in the tool bar. Note: heaps of these functions are broken, just ensure they are consistent with eachother!

DionBalmforth commented 5 years ago

Hey just testing around and the toolbar seems to have the same functionality as the buttons once the user has signed in/ entered without signing in. The toolbar is also available before the user signs in, by clicking "clone " the giving the same functionality as "continuing without signing in". Would it be possible to grey the git dropdown out if the user is still on the sign in screen or is there another way to avoid this unintended functionality?

nathan-cairns commented 5 years ago

Good point. I couldn't really find a nice way to do this when I was adding the toolbar menu. I'll take another look around though and let yah know how I go!

nathan-cairns commented 5 years ago

Due to the ridiculousness of the authenticate.ts file this has proven to be quite a time consuming feature to implement. I've added the functionality to unrestrict the menu option on sign in but have had no luck doing the inverse on sign out. Hopefully this will be done soon

DionBalmforth commented 5 years ago

Due to the ridiculousness of the authenticate.ts file this has proven to be quite a time consuming feature to implement. I've added the functionality to unrestrict the menu option on sign in but have had no luck doing the inverse on sign out. Hopefully this will be done soon

Ok that sounds all good, I'll check it out then might make create a new medium/ large issue to deal with the sign out if you think that is alright?

DionBalmforth commented 5 years ago

@Nathan-Cairns I think there are merge conflicts that need to be resolved before I can do my final checks

nathan-cairns commented 5 years ago

ah sweet as ill fix em later today!

nathan-cairns commented 5 years ago

Cool should be good to merge now

nathan-cairns commented 5 years ago

Sign out works as well btw

nathan-cairns commented 5 years ago

This feature ended up taking a lot longer to implement than expected due to large amount of time spent learning how electron works. There were also several issues with sifting through confusing code which was very time consuming. For example figuring out how the sign in / sign out functionality works and dealing with this changing in the master branch half way through implementation.