kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

Text overflow when searching for branch #177

Closed DionBalmforth closed 5 years ago

DionBalmforth commented 5 years ago

Describe the bug When searching for a branch if there are any names that are longer than the textbox they will overflow, which is very visually displeasing.

To reproduce Steps to reproduce the behavior:

Open a repository that has a long branch name
click the dropdown to search or create a branch

Expected behavior / Acceptance criteria Text should wrap or collapse within the textbox, there should be no overflow.

Screenshots

Desktop

OS: Windows 10

Related issues

132

joel-clarke commented 5 years ago

Getting this as well, approved. Might only be a small issue though, but this could just be me.

emipeanz commented 5 years ago

Approved, also getting this

SamuelZheng11 commented 5 years ago

Approved, I also get this on windows 10

emipeanz commented 5 years ago

Is it better to show the whole branch name and have a really long white box with name, or keep box the size it is and have the branch name scroll??????

aorthi commented 5 years ago

Oops sorry didn't mean to close the issue! Meant to reply to Em's comment about the design - I feel like the a long white box wouldn't look too good, would probably be best to scroll?

emipeanz commented 5 years ago

Oops sorry didn't mean to close the issue! Meant to reply to Em's comment about the design - I feel like the a long white box wouldn't look too good, would probably be best to scroll?

yea, was thinkin' that too 👍

cyrus-raitava commented 5 years ago

I have opened up a PR to fix this issue - @dbal234 does the search functionality actually work for branches? It doesn't seem to on my machine. If not, I'd be keen to open up a new issue and see this through.

DionBalmforth commented 5 years ago

I have opened up a PR to fix this issue - @dbal234 does the search functionality actually work for branches? It doesn't seem to on my machine. If not, I'd be keen to open up a new issue and see this through.

@cyrus-raitava the functionality does not seem to be working for me as well. I agree that an issue should be created for this.

cyrus-raitava commented 5 years ago

@cyrus-raitava the functionality does not seem to be working for me as well. I agree that an issue should be created for this.

Awesome! I've created a bug report here, feel free to approve it if you agree with it @dbal234 @emipeanz @aorthi @SamuelZheng11