search

kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

[BUG] FontAwesome CSS imported twice #182

Closed encryptededdy closed 5 years ago

encryptededdy commented 5 years ago

index.html now has FontAwesome imported twice. Can we fix this? Either use the node_module version (and maybe update it) or remove that and use the CDN version only.

This bug was introduced in PR #171

So now if we look in index.html we have two lines

    <link rel="stylesheet" href="node_modules/font-awesome/css/font-awesome.css" type="text/css">
    <link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.8.1/css/all.css" integrity="sha384-50oBUHEmvpQ+1lW4y57PTFmhCaXp0ML5d60M1M7uH2+nqUivzIebhndOJK28anvf" crossorigin="anonymous">
lukethompsxn commented 5 years ago

Approved. Is there much point in having the node_modules version since you will always require an internet connection to sign in / sign out hence we only need FontAwesome when it's accessible by the internet? The only benefit I see is using the package manager to handle the version updates.

emipeanz commented 5 years ago

approved

rmberriman commented 5 years ago

Approved