search

kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

[BUG] Changed file component resetting #187

Open Z-Qi opened 5 years ago

Z-Qi commented 5 years ago

Describe the bug In the file panel, if there is a file with uncommitted changes, the file keeps rerendering. This can be seen when the tickbox is selected but after around 1 to 2 seconds it will reset.

This does not occur in surrounding elements, as noted in the gif below, the 'Select All' tickbox and commit message text area do not rerender.

To reproduce Steps to reproduce the behavior:

  1. Open a repository
  2. If there are no uncommited changes, make one
  3. The file component should now flicker every few seconds and reseting any state within the element

Expected behavior / Acceptance criteria File component should not be rerendering.

Screenshots RdHAojsan1

Desktop:

rmberriman commented 5 years ago

Confirm that bug exists for new files (For modified files the tick doesn't reset when flicker) as seen below:

Approved.