kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

Closes #182 - Font-Awesome Imported Twice #217

Closed lukethompsxn closed 5 years ago

lukethompsxn commented 5 years ago

Related Issue/Keyword:

Closes #182

Description:

Font-Awesome was being imported twice, one from cdn and one from node-modules. The node-modules version was removed as it did not support some of the icons which were required.

Testing:

Steps for manual testing:

  1. remove node modules directory
  2. run npm install
  3. run npm start
  4. after signing in, verify that the log out icon (top right hand corner is displayed)
  5. verfiy no other icons are missing

Checklist:

lukethompsxn commented 5 years ago

From what I can see it all looks good except for the refresh button, which should be next to these icons. Screenshot_3

Thanks for pointing this out! I have fixed it and pushed the changes 😄