kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

Close #52 - Add github profile picture support for noreply.github.com emails #227

Closed liamtbrand closed 5 years ago

liamtbrand commented 5 years ago

Related Issue/Keyword:

Closes #52.

Description:

So I spent a few of hours on this but it is proving ridiculously difficult to get the github usernames from the name+email combination because of rate limits on the github api and the asynchronicity of the whole thing. See https://api.github.com/rate_limit for rate limits. To retrieve the github username the following endpoint can be used: https://api.github.com/search/users?q=liamtbrand%40gmail.com%20in%3Aemail.

To close this issue what I have done is retrieve the username and thus the profile picture for anyone who has their email specified as the github no reply email. This was done similar to #123 for the same reasons @Buster-Darragh-Major provided in the description.

Fetching profiles for non-github emails could be done, however a new issue should probably be opened for retrieving the usernames. Otherwise I think it is sufficient to fetch the profile pictures for the github user emails only.

Testing:

Must be done manually.

Steps for manual testing:

  1. Open VisualGit.
  2. Open a repository with github and non github users. (VisualGit is good).
  3. Verify that users with @noreply.github.com emails have their github profile picture shown.
  4. Verify that users with other emails have the first letter of their name or email shown.

Checklist:

liamtbrand commented 5 years ago

Related to this thread, there appears to be an issue already open for fetching the github username from the name+email combination. See #11.