Fixes #55 - Pushing changes before committing crashes application

SheepySean commented 5 years ago

Related Issue/Keyword:

Fixes #55

Description:

Prior to this commit. It was possible to push to the remote without having any file changes comitted. This could cause crashing to the application by needlessly calling the node-git API and always was pretty bad UX. This PR introduces functionality to check if there are any changes that need to be pushed to the repo before pushing them. If there are 0 then the push is ignored as it is redundant. It's important to note here, this functionality could be leveraged on the ui side of things to inform the user how many commits are not pushed.

BIG NOTE: This PR does not unfortunately fix all pushing errors as the node-git API can actually cause segmentation faults with its threading policy when pushing so that's really fun. I've spent many hours researching this and it appears others having the problem, and its not quite fixable. Good news, if node-git fixes their stuff then this would also be fixed. This PR predominately helps to guard the pushing functionality to when its only needed. https://github.com/nodegit/nodegit/issues/1591

Testing:

Steps for manual testing:

Open a repo that has a remote registered with it
Immediately click push and note the dialog saying there are no changes to push.
Make a change, click push again and note the dialog saying there are no changes to push.
Commit the change and click push. The push will continue as per normal.

Checklist:

[x] Latest master merged/rebased into your feature branch
[x] Tests covering all changes
[x] Meets the projects coding conventions
[x] No out of scope changes
[x] @Mentioned any relevant team members
[x] No failure when running the linter (npm run lint)
[x] Included a relevant gif (search here for inspiration)

twchen97 commented 5 years ago

Doing the manual tests, the dialog showing no changes to push is looking good and I can do steps 1, 2, and 3 successfully. For some reason my modified files aren't showing up on VisualGit anymore, and it's not letting me commit so I can't test the last step for manual testing.

It could be just my machine, but are you getting this problem as well? The issue is probably out of your scope for this PR but I don't think I can finish the manual testing without that being resolved first.

SheepySean commented 5 years ago

Doing the manual tests, the dialog showing no changes to push is looking good and I can do steps 1, 2, and 3 successfully. For some reason my modified files aren't showing up on VisualGit anymore, and it's not letting me commit so I can't test the last step for manual testing.

It could be just my machine, but are you getting this problem as well? The issue is probably out of your scope for this PR but I don't think I can finish the manual testing without that being resolved first. @twchen97

I am also getting those issues, and also on master so its not this feature breaking it for whatever reason.

My suggestion for testing is using the command line to commit files. So testing wise this would be for step 4:

Modify a file

Through the command line, commit this file but DO NOT push it:

git add my_file.txt
git commit -m "Some cool commit message"

Proceed with this push by clicking the push icon on VisualGit. You should see a successful push occur

kblincoe / VisualGit_SE701_2019_1