kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

[BUG] Modified files not being displayed in the modified files panel #235

Closed SheepySean closed 5 years ago

SheepySean commented 5 years ago

Describe the bug Prior to a couple of days ago, modified files would be directly displayed in the modified files panel. Recently that no longer occurs and is evident on master. This change appeared to found around the 4th or 5th of April.

To reproduce Steps to reproduce the behavior:

  1. Open VisualGit
  2. Open a local repo or clone another from online
  3. Modify a file in this repo (add to, create or delete)

Expected behavior / Acceptance criteria The modified file should appear in the modified files section of VisualGit

Screenshots

The file a thing.txt has been created and should be visibly modified in VisualGit. Running git status through the command line shows that there is a known change by Git

Desktop (please complete the following information):

Additional context

It appears that there is this error thrown when getting all commits for a repo. It may be related to this.

Related issues

178 <- Initial PR that introduced this functionality. At this time the functionality was definitely working.

encryptededdy commented 5 years ago

Approved. I will also chuck an urgent on this since this breaks the core functionality of VisualGit (you can't make commits anymore!)

SheepySean commented 5 years ago

Added it as medium issue in case any fixes are not straight forward or this bug requires extensive investigation

twchen97 commented 5 years ago

Approved, I've noticed this as well. Agree it's urgent and medium.

twchen97 commented 5 years ago

My bad, didn't mean to close!

rmberriman commented 5 years ago

Approved - very urgent