search

kblincoe / VisualGit_SE701_2019_1

1 stars 0 forks source link

[BUG] Move Mac_Application `Quit` option to Window Dropdown #245

Closed lukethompsxn closed 5 years ago

lukethompsxn commented 5 years ago

Describe the bug This was introduced with #124 when the quit keyboard shortcut for mac was added. Although we want to retain this functionality, it should be moved from the Mac_Application heading and placed into the Window dropdown, this allows us to remove the Mac_Application heading and clean up the menu.

To reproduce Steps to reproduce the behavior:

  1. Start visual git

Expected behavior / Acceptance criteria The Quit option as documented in the screenshot should be displayed under the Window dropdown menu option and the Mac_Application menu option should be removed

Screenshots image

Desktop (please complete the following information):

Pointers The menus structure is defined in index.js

Related issues Introduced in #124

AbhinavBehal commented 5 years ago

Approved, I've seen this menu option on Windows

rmberriman commented 5 years ago

Approved - good idea!

bcox280 commented 5 years ago

Approved, would be nice to see that menu option moved