The quit option and keyboard shortcut registration occurred in the Mac_Application menu which was unnecessary as quit better fits the Window menu. As a result, quit was moved and Mac_Application menu option was removed.
In addition to this, there was a Close Window option in the Window menu which had the same functionality as Quit, but without the keyboard shortcut, hence it was removed.
Testing:
Steps for manual testing:
Open VisualGit, at any point verify that Mac_Application no longer appears in the menu bar
Verify that Close Window option is not present in the Window menu, but that Quit is
Verify that cmd + Q (mac) or ctrl + Q (windows) quits the application
Checklist:
[x] Latest master merged/rebased into your feature branch
[x] Tests covering all changes
[x] Meets the projects coding conventions
[x] No out of scope changes
[x] No failure when running the linter (npm run lint)
Related Issue/Keyword:
Closes #245
Description:
The quit option and keyboard shortcut registration occurred in the
Mac_Applicationmenu which was unnecessary as quit better fits theWindowmenu. As a result, quit was moved andMac_Applicationmenu option was removed.In addition to this, there was a
Close Windowoption in theWindowmenu which had the same functionality as Quit, but without the keyboard shortcut, hence it was removed.Testing:
Steps for manual testing:
Mac_Applicationno longer appears in the menu barClose Windowoption is not present in theWindowmenu, but thatQuitiscmd + Q(mac) orctrl + Q(windows) quits the applicationChecklist:
npm run lint)