[MAINTENANCE] Clean up color.ts

nathan-cairns commented 5 years ago

Description Currently the color.ts file is a bit of a mess with a heap of code duplication. It would be great if this code could be cleaned up to make it easier to alter in the future. This can probably be done pretty easily with the introduction / use of a few well placed variables. It would also be good to introduce constants for different colours etc.

Acceptance criteria

Clean up the color.ts file, getting rid of all code duplication, introduction of constants for colours.
No loss / change in functionality

rmberriman commented 5 years ago

Approved - that file is a mess, would make it more readable and constants are a good idea as it will help alter the colour scheme at a later date.

bcox280 commented 5 years ago

Approved! It's painful to look at this file atm.

swimuel commented 5 years ago

Approved.

AbhinavBehal commented 5 years ago

Updating this to a medium sized issue since it took a fair amount of time to come up with a better design for handling different themes.

kblincoe / VisualGit_SE701_2019_1

[MAINTENANCE] Clean up color.ts #251